[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev lynx2.8.3dev.11a.patch
From: |
Leonid Pauzner |
Subject: |
Re: lynx-dev lynx2.8.3dev.11a.patch |
Date: |
Thu, 14 Oct 1999 13:04:53 +0400 (MSD) |
13-Oct-99 22:16 T.E.Dickey wrote:
> -- sorrrrry about that.
> I'll put this in the next patch (since it was rather large, there may be other
> ones that I missed - so I'll wait til tomorrow to see). The infinite loop
> is fixed by adding a break statement at the end of do_check_recall; I also
> had second thoughts about the FirstURLRecall flag - made it in/out. And there
Seems few more flags should be in/out,
I am particularly interested in:
force_load (LYK_digit - have changed value but seems not returned),
prev_target (LYK_WHEREIS - seems OK since `prev_target' is a bixed buffer,
but could we made it as allocated string to made things clear?)
refresh_screen (I am sceptical on this flag:
all `partial display' calls match without the flag
so it could be useful for LYK_REFRESH only
but *probably* also few LYSystem() calls to update
the screen before/after an external editor invocation or so -
currently called from many "internal pages" but seems
unused in fact).
> were a couple of K&R nits that were from dev.9 in makeuctbc.c
> #
> ------------------------------------------------------------------------------
> # LYMainLoop.c | 28 +++++++++++++++-------------
> # chrtrans/makeuctb.c | 6 +++---
> # 2 files changed, 18 insertions, 16 deletions
> #
> ------------------------------------------------------------------------------
> Index: src/LYMainLoop.c
> --- lynx2.8.3dev.11+/src/LYMainLoop.c Wed Oct 13 10:29:33 1999
> +++ lynx2.8.3dev.11a/src/LYMainLoop.c Wed Oct 13 21:55:50 1999
> @@ -536,7 +536,7 @@
> int, URLTotal,
> int *, URLNum,
> int, recall,
> - BOOLEAN, FirstURLRecall)
> + BOOLEAN *, FirstURLRecall)
> {
> char *cp;
> @@ -582,21 +582,21 @@
> break;
> }
> if (recall && ch == UPARROW) {
> - if (FirstURLRecall) {
> + if (*FirstURLRecall) {