[lwip-users] Etharp Mystery

[Paul Clarke]

Hi

 

In etharp.c find_entry() find entry will always (try to) add an ARP entry even

when it is not required (flags == 0). Here is my patch. It should probably return

something other than ERR_MEM perhaps ERR_RTE or ERR_ARG?

 

The dhcp.c code may need to be updated as the etharp_query(..)

call in it uses a NULL pbuf which means that the etharp_query will not

set the ETHARP_CREATE flag. Should etharp_query() always set

ETHARP_CREATE? 

 

Finally in etharp_ip_input should the update_arp_entry have the

create flag set to zero? Or set to CREATE only if the destination is

our ip address?

 

Paul

 

netif/etharp.c cvs head

263a264,269
>   if (!flags & ETHARP_CREATE)
>   {
>     // dont create arp entry if not required
>     return ERR_MEM;
>   }
>