[lwip-devel] [bug #57706] dhcp/acd integration: acd is not stopped

[Simon Goldschmidt]

Update of bug #57706 (project lwip):

                  Status:                    None => In Progress            
             Assigned to:                    None => goldsimon              

    _______________________________________________________

Follow-up Comment #4:

Jasper,
sorry for taking more than a year. The whole corona thing changed my life very
much regarding time for lwIP. Anyway, I'm trying to catch up right now, and
this one is the main blocker for 2.2.0 (and this release is required to dump
the 2.1.x branch), so....

I'm still not convinced acd_remove() is not required in dhcp_stop(): the next
cll to acd_add() again on the next call to dhcp_start() succeeds because of
special check for adding existing acd struct, but

a) we often execute some code just to see that the state is OFF and 

b) I think that the counterpart to dhcp_start() is dhcp_stop(). As such, the
logical counterpart to calling acd_add() from dhcp_start() should be calling
acd_remove() from dhcp_stop().

I admit there's no memory issue when using dhcp_set_struct() (as I do it,
too).

As a side note (for the 2.2.0 release): the autoip module does not seem to
stop acd, too, so that will have to be fixed before the relase as well :-(

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?57706>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/