[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #54933] Bad assertion in lwip_poll_dec_sockets_used()
From: |
Joan Lledó |
Subject: |
[lwip-devel] [bug #54933] Bad assertion in lwip_poll_dec_sockets_used() |
Date: |
Thu, 1 Nov 2018 13:14:54 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 |
URL:
<https://savannah.nongnu.org/bugs/?54933>
Summary: Bad assertion in lwip_poll_dec_sockets_used()
Project: lwIP - A Lightweight TCP/IP stack
Submitted by: jllledo
Submitted on: Thu 01 Nov 2018 06:14:53 PM CET
Category: sockets/netconn
Severity: 3 - Normal
Item Group: Faulty Behaviour
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release: None
lwIP version: git head
_______________________________________________________
Details:
Hello,
I wrote a patch to remove the assertion in lwip_poll_dec_sockets_used(), b/c
it seems to me it allows clients to abort the stack by just calling poll()
with an invalid pollfd array. In particular, any pollfd which 'fd' is not a
valid port number makes the assertion true.
Besides, that assertion is not in lwip_poll_inc_sockets_used(), then I don't
know why is it in lwip_poll_dec_sockets_used().
What do you think?
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Thu 01 Nov 2018 06:14:53 PM CET Name:
0001-Remove-assertion-about-the-end-of-pollfd-array.patch Size: 822B By:
jllledo
<http://savannah.nongnu.org/bugs/download.php?file_id=45346>
_______________________________________________________
Reply to this item at:
<https://savannah.nongnu.org/bugs/?54933>
_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/
- [lwip-devel] [bug #54933] Bad assertion in lwip_poll_dec_sockets_used(),
Joan Lledó <=