[lwip-devel] [patch #9523] MDNS responder should reply after a random timeout

[Simon Goldschmidt]

Follow-up Comment #19, patch #9523 (project lwip):

I'm happy someone's working on this!

But the patch is hard to review since it is very big and contains code
restructuring as well as new code.

I know I said "post a single patch, not multiple" last time, but what I meant
is something different. To review a patch, it's best to separate it into
smaller commits that show different logical steps, not just your history of
how you did what and when.

I.e. it would greatly speed up the review process if you could provide a
patchset that e.g. first has all the code changes and then separates the files
(or the other way round). And ideally another patch (as the first in the
series) that fixes bugs in the existing code.

I can well understand if this is too much work for you, but this is how good
patches should look like. This is inspired by the Linux way, yes, and lwIP may
not keep up with this, but still: I'll try to find the time to review this
before pushing. Getting this input from you will speed up the process.

Thanks again for sharing your work.

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9523>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/