[lwip-devel] [task #15072] SNMP support for notifications and informs (v2c)

[Dirk Ziegelmeier]

Follow-up Comment #1, task #15072 (project lwip):

The patch contains changes in err.h which seem to be unused, e.g. typedef ...
err_status_t and #define ERR_IS_FATAL()

The patch also contains lots of lines with duplicated BUILD_EXEC() macros,
e.g. "BUILD_EXEC( BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) ) );"

The patch also has a lot of compile errors, since you use "return" statements
in functions with return type "void", e.g. snmp_trap_header_enc_v1_specific,
snmp_trap_header_enc_v2c_specific, 
snmp_trap_header_en.

In function snmp_send_trap_or_notification_or_inform_generic() you declare
variables AFTER statements (struct snmp_obj_id snmp_trap_oid =  { 0 };)


Complete compile errors from MSVC:


"W:\lwip\lwip\build\ALL_BUILD.vcxproj" (Standardziel) (1) ->
"W:\lwip\lwip\build\contrib\ports\win32\example_app\example_app.vcxproj"
(Standardziel) (3) ->
"W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj"
(Standardziel) (4) ->
(ClCompile Ziel) ->
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(379): warning C4047:
'initializing' : 'u16_t' differs in levels of indirection from 'void *'
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(738): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(739): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(745): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(746): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(751): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(752): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(759): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(760): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(765): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(766): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(771): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(772): warning C4098:
'snmp_trap_header_enc_v1_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(790): warning C4098:
'snmp_trap_header_enc_v2c_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(791): warning C4098:
'snmp_trap_header_enc_v2c_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(796): warning C4098:
'snmp_trap_header_enc_v2c_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(797): warning C4098:
'snmp_trap_header_enc_v2c_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(802): warning C4098:
'snmp_trap_header_enc_v2c_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(803): warning C4098:
'snmp_trap_header_enc_v2c_specific' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(816): warning C4142: benign
redefinition of type
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(821): warning C4098:
'snmp_trap_header_enc' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(826): warning C4098:
'snmp_trap_header_enc' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(827): warning C4098:
'snmp_trap_header_enc' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(831): warning C4098:
'snmp_trap_header_enc' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(832): warning C4098:
'snmp_trap_header_enc' : 'void' function returning a value
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(835): warning C4013:
'snmp_trap_header_enc_pdu' undefined; assuming extern returning int
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]


"W:\lwip\lwip\build\ALL_BUILD.vcxproj" (Standardziel) (1) ->
"W:\lwip\lwip\build\contrib\ports\win32\example_app\example_app.vcxproj"
(Standardziel) (3) ->
"W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj"
(Standardziel) (4) ->
(ClCompile Ziel) ->
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(686): error C2059: syntax error :
'if' [W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(686): error C2059: syntax error :
'}' [W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(686): error C2059: syntax error :
'return'
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(686): error C2059: syntax error :
'}' [W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(686): error C2059: syntax error :
')' [W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(686): error C2059: syntax error :
')' [W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(688): error C2059: syntax error :
'while'
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(694): error C2059: syntax error :
'return'
[W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]
  ..\..\..\..\..\src\apps\snmp\snmp_traps.c(695): error C2059: syntax error :
'}' [W:\lwip\lwip\build\contrib\ports\win32\example_app\lwipallapps.vcxproj]


    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/task/?15072>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/