[lwip-devel] [bug #54253] same LCP magic number after power-up.

[Sergey A. Borshch]

URL:
  <http://savannah.nongnu.org/bugs/?54253>

                 Summary: same LCP magic number after power-up.
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: dushevny
            Submitted on: Thu 05 Jul 2018 09:23:13 PM UTC
                Category: PPP
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

magic_init() first time called from ppp_init(), which is called from
lwip_init(). If system has no RTC, sys_jiffies() returns same value in this
moment after every power-up or system reset. This value used in LCP magic
number generation after ppp_connect(), which leads to same magic number after
every restart. Subsequent magic_randomize() calls takes place in ppp_input(),
after magic number generation.

 Suggestion: call magic_randomize() somewhere near start of ppp_connect() as
ppp_connect called after modem init which takes random time.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?54253>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/