[lwip-devel] [bug #52692] tcp: handle pcb->snd_queuelen and chained pbufs during segment split

[Joel Cunningham]

URL:
  <http://savannah.nongnu.org/bugs/?52692>

                 Summary: tcp: handle pcb->snd_queuelen and chained pbufs
during segment split
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jcunningham
            Submitted on: Tue 19 Dec 2017 03:45:04 PM UTC
                Category: TCP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: In Progress
                 Privacy: Public
             Assigned to: jcunningham
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

Found another issue in tcp_split_unsent_seg() where a chained pbuf was not
correctly updating pcb->snd_queuelen during trimming and snd_queuelen would
desynchronize if pbuf_realloc() freed some of the chain

Also, use pbuf_clen() for adding the new remaining segment rather than ++. The
new remaining segment should always be one pbuf due to the semantics of
PBUF_RAM, but this follows the best practice of using pbuf_clen()





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 19 Dec 2017 03:45:04 PM UTC  Name:
0001-tcp-handle-pcb-snd_queuelen-and-chained-pbufs-during.patch  Size: 2KiB  
By: jcunningham

<http://savannah.nongnu.org/bugs/download.php?file_id=42683>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?52692>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/