lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #52611] Incorrect use of ctype macros?


From: Mike Kleshov
Subject: [lwip-devel] [bug #52611] Incorrect use of ctype macros?
Date: Thu, 7 Dec 2017 04:22:28 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

URL:
  <http://savannah.nongnu.org/bugs/?52611>

                 Summary: Incorrect use of ctype macros?
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: kleshov
            Submitted on: Thu 07 Dec 2017 12:22:27 PM MSK
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

A recent commit casts arguments to int before invoking ctype macros:
http://git.savannah.nongnu.org/cgit/lwip.git/commit/?id=eb30dbfdc5d458d4b996987d8be9c818743e59e5
If I remember correctly, gcc complains about this since arguments could be
negative and this would lead to accessing an array with a negative index.
So I suggest casting arguments to unsigned int instead.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?52611>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]