lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9262] Support for 32bit errno codes


From: Simon Goldschmidt
Subject: [lwip-devel] [patch #9262] Support for 32bit errno codes
Date: Fri, 17 Feb 2017 06:18:36 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Follow-up Comment #1, patch #9262 (project lwip):

It would have helped to include a description in the original submission.

Excerpt from lwip-users:
"I was trying to compile LwIP in the Hurd and many warnings like this
one raised when compiling sockets.c:

./api/sockets.c: In function 'lwip_getsockopt_impl':
./api/sockets.c:1892:12: warning: large integer implicitly truncated
to unsigned type [-Woverflow]
return EBADF;
^~~~~

EBADF macro is defined in the Hurd's errno.h:"

Essentially, Hurd's errnos are defined in an enum (which is of type 'int' by
the standard) and include "(0x10 << 26)", which is of course way out of our
u8_t.

However, there are two things wrong with the patch:
a) struct sock -> err must be changed, too
b) you'd want to use 'int' instead of 'u32_t' to stay portable

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9262>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]