[lwip-devel] [bug #46467] ip_frag() shouldn't modify pbuf in case of a retransmission

[Zach Smith]

Follow-up Comment #13, bug #46467 (project lwip):

I think I found the problem. In ip4_frag() just after the loop where the
mirrored pbufs are created (the while (left_to_copy) loop), the poff
adjustment should be:

[line 788]
poff += newpbuflen;
instead of
poff = newpbuflen;

poff starts at IP_HLEN and should be incremented through the pbuf as fragments
of it are sent - because now it is an offset from the original pbuf payload.

I changed that line and the fragmenting now works for me. Re-transmissions of
the fragments work too.

My application always sends with contiguous pbufs (PBUF_RAM) but the code
looks like it will also work for chained pbufs. I stepped through with my
debugger and created a fake chained pbuf to see if it would handle it and it
seemed to do it correctly.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?46467>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/