[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #7905] Add RFC3542-style checksum compuation on raw,
|
From: |
Philip Gladstone |
|
Subject: |
[lwip-devel] [patch #7905] Add RFC3542-style checksum compuation on raw, IPv6 sockets. |
|
Date: |
Fri, 21 Feb 2014 03:20:34 +0000 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 |
Follow-up Comment #2, patch #7905 (project lwip):
I'm not convinced that this patch is correct -- I think that the lines
chksum = ip6_chksum_pseudo(q, pcb->protocol, q->tot_len, ipX_2_ip6(src_ip),
ipX_2_ip6(dst_ip));
+ (u16_t )(((u8_t *)q->payload) + pcb->chksum_offset) = chksum;
should refer to "p" and not "q".
At least, if I use the original code, then it doesn't work, and if I use the
"p" version, then it does work.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?7905>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/