[lwip-devel] [bug #36424] PPPoED, packets with error message tag are silently tossed

[Sylvain Rochet]

URL:
  <http://savannah.nongnu.org/bugs/?36424>

                 Summary: PPPoED, packets with error message tag are silently
tossed
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: gradator
            Submitted on: Mon 07 May 2012 02:58:50 PM GMT
                Category: None
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:

If a PPPoED message with an optional error message is received, it is silently
tossed due to the "goto done;" which goes to the far end of the function.

We can as well use a "goto breakbreak;" or let the loop finish because the
message is always the latest tag.

Here is a patch that fix this behavior, it also remove the useless errortag
variable and therefore save 4B on the stack.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 07 May 2012 02:58:50 PM GMT  Name:
lwip-pppoed-packet-with-error-message-tag-silently-tossed.patch  Size: 1kB  
By: gradator

<http://savannah.nongnu.org/bugs/download.php?file_id=25813>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?36424>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/