[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-devel] PING_USE_SOCKETS==0 causes abort()
From: |
Kieran Mansley |
Subject: |
Re: [lwip-devel] PING_USE_SOCKETS==0 causes abort() |
Date: |
Thu, 22 Sep 2011 20:10:25 +0100 |
On 22 Sep 2011, at 20:00, Gisle Vanem wrote:
>
> Seems the handling of ICMP_ECHO in ping_recv() is too careless.
> Not knowing the details of the raw API, how does ping_recv() know it's even
> receiving a IP-packet? Seems it's just assuming the packet
> is > PBUF_IP_HLEN.
Yes, it wouldn't surprise me if the ping code could be easily confused by
malformed ICMP frames. Patches that make it more robust without making the
code bloated would be welcome.
Kieran