[lwip-devel] [patch #7449] allow tcpip callback from interrupt with static memory message

[Stephane Lesage]

Follow-up Comment #2, patch #7449 (project lwip):

>I don't understand the renaming of the message types, which seems to be the
bulk of this patch.
>Can you explain what's going on here?
>I get the feeling that the pool/stat bit is really a flag rather than a whole
new set of types.
>Perhaps we need a flags field in the tcpip_msg structure.

Hi, yes basically we need a flag to tag the message as static or dynamic. But
this forces us to explicitely set it, and it adds a variable to the structure
for only 1 bit.

Actually we don't need the flag for all message types.
In the current code, messages types already code implicitely their
dynamic/static nature.

So I chose to add a single new type for callback request with a static
message. And to make things clearer, rename messages types with explicit
reference to their static/dynamic allocation.

(Another option would be to embedded the flag as MSB in the message type and
casting)


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7449>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/