[lwip-devel] [bug #32418] tcp_seg->dataptr: does it point to tcp-data or -options?

[Simon Goldschmidt]

URL:
  <http://savannah.nongnu.org/bugs/?32418>

                 Summary: tcp_seg->dataptr: does it point to tcp-data or
-options?
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Do 10 Feb 2011 20:17:36 GMT
                Category: TCP
                Severity: 2 - Minor
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:

There seems to be a discrepancy (introduced by the tcp_create_segment()
function introduced with TCP_OVERSIZE?):

on 02.09.2011, MK wrote on lwip-devel:

For tcp_seg, is the dataptr in it pointing to the beginning of the tcp
data or to the beginning of the options at the end of the tcp header?
I think there is a discrepancy - For TCP_WRITE_FLAG_COPY in tcp_write,
it gets set via tcp_create_segment and is set to the beginning of the
options, for other cases, it is set similarly, but later adjusted to
point to the beginning of the data - line 593 -

   /* Fix dataptr for the nocopy case */
   if ((apiflags & TCP_WRITE_FLAG_COPY) == 0) {
     seg->dataptr = (u8_t*)arg + pos;
   }





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?32418>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/