[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #7088] DNS with custom malloc/realloc contains a dou
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [patch #7088] DNS with custom malloc/realloc contains a double free in RAM pbuf realloc |
Date: |
Thu, 11 Feb 2010 15:09:39 +0000 |
User-agent: |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 |
Follow-up Comment #2, patch #7088 (project lwip):
I do see problems here, for example in ip_input: at the start of the
function, iphdr is set to p->payload. That patch attached here reallocs the
pbuf but does *not* change all pointers that already point into p->payload!
There are certainly other places where this change will hurt. Also, I don't
think this change is really "lightweight": it leads to "realloc" using memcpy
for rx packets although this wouldn't be necessary.
I very strongly vote against this going in!! Instead, for such heap
implementations, mem_realloc should do nothing, as MEM_LIBC_MALLOC does!
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?7088>
_______________________________________________
Nachricht geschickt von/durch Savannah
http://savannah.nongnu.org/
- [lwip-devel] [patch #7088] DNS with custom malloc/realloc contains a double free in RAM pbuf realloc, Ken Smith, 2010/02/09
- [lwip-devel] [patch #7088] DNS with custom malloc/realloc contains a double free in RAM pbuf realloc, Kieran Mansley, 2010/02/11
- [lwip-devel] [patch #7088] DNS with custom malloc/realloc contains a double free in RAM pbuf realloc,
Simon Goldschmidt <=
- [lwip-devel] [patch #7088] Support for mem_realloc moving memory, Simon Goldschmidt, 2010/02/12
- [lwip-devel] [patch #7088] Support for mem_realloc moving memory, Simon Goldschmidt, 2010/02/17
- [lwip-devel] [patch #7088] Support for mem_realloc moving memory, Ken Smith, 2010/02/17
- [lwip-devel] [patch #7088] Support for mem_realloc moving memory, Simon Goldschmidt, 2010/02/18
- [lwip-devel] [patch #7088] Support for mem_realloc moving memory, Kieran Mansley, 2010/02/18
- [lwip-devel] [patch #7088] Support for mem_realloc moving memory, Ken Smith, 2010/02/18
- [lwip-devel] [patch #7088] Support for mem_realloc moving memory, Kieran Mansley, 2010/02/18
- [lwip-devel] [patch #7088] Support for mem_realloc moving memory, Ken Smith, 2010/02/18