|
From: | Simon Goldschmidt |
Subject: | [lwip-devel] [bug #27352] Change ip_addr from struct to typedef (u32_t) |
Date: | Thu, 04 Feb 2010 20:15:08 +0000 |
User-agent: | Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 |
Update of bug #27352 (project lwip): Status: Need Info => In Progress _______________________________________________________ Follow-up Comment #27: I've done some preliminary work on this: - changed all the code to not know about the actual IP address type layout and use defines instead (no performance darwback but much cleaner code - also regarding IPv6 upgrade); - changed "struct ip_addr" to "struct _ip_addr" and added a "typedef struct _ip_addr ip_addr_t" - replaced usage of "struct ip_addr" by "ip_addr_t" throughout the stack This means we are now relatively free to change the actual typedef of the IP address. However, I'm still not convinced it all just works when we now just change the typedef from "typedef struct ip_addr ip_addr_t" to "typedef u32_t ip_addr_t": For example we would have to pay attention when passing the ip address from protocol headers to other functions (e.g. checksum calculation), or do compilers warn about that? _______________________________________________________ Reply to this item at: <http://savannah.nongnu.org/bugs/?27352> _______________________________________________ Nachricht geschickt von/durch Savannah http://savannah.nongnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |