[lwip-devel] Re: [lwip-users] lwIP 1.3.1 second release candidate

[address@hidden]

Anyone against the attached patch being committed before 1.3.1? It's 
only debug output, so the risk for release code should not be very high, 
anyway...

Simon

--
Index: tcp.c
===================================================================
RCS file: /sources/lwip/lwip/src/core/tcp.c,v
retrieving revision 1.93
diff -u -r1.93 tcp.c
--- tcp.c    25 Jun 2009 09:57:36 -0000    1.93
+++ tcp.c    27 Jul 2009 20:14:35 -0000
@@ -1399,6 +1399,7 @@
  if (flags & TCP_CWR) {
    LWIP_DEBUGF(TCP_DEBUG, ("CWR "));
  }
+  LWIP_DEBUGF(TCP_DEBUG, ("\n"));
}

/**
Index: tcp_in.c
===================================================================
RCS file: /sources/lwip/lwip/src/core/tcp_in.c,v
retrieving revision 1.109
diff -u -r1.109 tcp_in.c
--- tcp_in.c    25 Jun 2009 09:57:36 -0000    1.109
+++ tcp_in.c    27 Jul 2009 20:22:53 -0000
@@ -408,6 +408,7 @@
    LWIP_DEBUGF(TCP_DEBUG, ("TCP connection request %"U16_F" -> 
%"U16_F".\n", tcphdr->src, tcphdr->dest));
#if TCP_LISTEN_BACKLOG
    if (pcb->accepts_pending >= pcb->backlog) {
+      LWIP_DEBUGF(TCP_DEBUG, ("tcp_listen_input: listen backlog 
exceeded for port %"U16_F"\n", tcphdr->dest));
      return ERR_ABRT;
    }
#endif /* TCP_LISTEN_BACKLOG */





Chris_S wrote:
> A request I have, is to get a "\n" put in about line 1402 in TCP.C
> This is the debug flags output, and there is no CR.
> Builds up a huge line length when I ran debug.
>
> Also, it would have saved me a lot of time yesterday if
> there would have been a LWIP_DEBUGF()
> in this block at line 409 in TCP_IN.C
>
> #if TCP_LISTEN_BACKLOG
>     if (pcb->accepts_pending >= pcb->backlog) {
>       return ERR_ABRT;
>     }
> #endif /* TCP_LISTEN_BACKLOG */
>
> This nasty little section causes the CPU to bail out of the routine
> quietly, completely, without any notice!  
>
> I added this debug msg:
>
> #if TCP_LISTEN_BACKLOG
>     if (pcb->accepts_pending >= pcb->backlog) {
>       LWIP_DEBUGF(TCP_DEBUG, "ERROR: Listen Pending Backlog Exceeded \n");
>       return ERR_ABRT;
>     }
> #endif /* TCP_LISTEN_BACKLOG */
>
>
>
> Thanks, Chris.
>
>
>
>
> _______________________________________________
> lwip-users mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/lwip-users
>
>