[lwip-devel] [bug #11400] ARP multi-packet-queue modifies TCP unsent/unacked segment packet pbuf chain into packet queue

[Jonathan Larmour]

Follow-up Comment #30, bug #11400 (project lwip):

Oh yes, that is the same thing - I thought it was describing something
different, sorry.

I think this is quite an important "optimisation". If someone's using a
PBUF_REF in the first place, it's probably because the  data, of which the
pbuf is a part, is potentially large (at least compared to free memory) and
they want/need to be particularly space efficient.

I also don't think it's that much more complex.

newp->next = oldp->next;
newp->tot_len = oldp->tot_len;
pbuf_ref(newp->next);

Adding this after Simon's done won't work if Simon is going to take the
pbuf_copy() approach. Simon's work would need to be undone and replaced with
something more like pbuf_take() again, making Simon's efforts somewhat
pointless. After all, pbuf_copy() was only needed when you didn't want to
change the original pbufs.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?11400>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/