Re: [lwip-devel] recent 32-bit alignment patch in HEAD and requirement for libc

[Atte Kojo]

On Thu, 2004-04-29 at 02:14, Leon Woestenberg wrote:
> reviewing some lwIP code, I noticed that the new 32-bit alignment
> patch (now in HEAD) relies on a standard C library function:
> 
>      if (!memcmp(ipaddr, &arp_table[i].ipaddr, sizeof(struct ip_addr))) {
> 
> As far as I know, lwIP did not require the C library before.
> 
> Can other developers confirm this? If true, we may need to remove this
> requirement again.

There is a macro called ip_addr_cmp() in ip_addr.h. I think it should be
used instead of memcmp().

-- 
The thing looks obvious, but I'd rather not apply it to my tree until
somebody sends me the above back as a tested patch.. Call me a sissy. 

- Linus Torvalds on linux-kernel