Re: [Ltib] Handling PKG_KERNEL_LEAVESRC?

[Peter Barada]

On 02/16/2012 09:13 AM, Peter Barada wrote:
> On 02/16/2012 03:08 AM, Stuart Hughes wrote:
>> Maybe the best thing would be to allow this per project using a setting in 
>> the .ltibrc file. That way a user would knowingly turn off clobber 
>> protection.  
> That would work perfectly!
>
> Then if someone tries using --clobber w/o the appropriate flag set in
> .ltibrc it will ignore it (and spit out an appropirate message).
>
> I'll code something up against the current LTIB and send it out.
Attached.  To enable it you need both %allow_clobber in .ltibrc set to
non-zero *and* --clobber on the command line.  To test you can try:

./ltib -p skell -m prep
touch dist/lfs-5.1/skell/*.spec
./ltib --clobber -p skell

In my case I have a OMAP-specific skell-omap-logic.spec.  If I have
%allow_clobber enabled I see:

address@hidden:~/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0$
./ltib --clobber -p skell

Processing platform: Logic OMAP3530/03&DM3730/03 reference boards
===================================================================
using config/platform/omap_logic/.config

Processing: skell-omap_logic
==============================
Build path taken because: directory build, spec file newer than rpm,
Clobber forces removal of
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/rpm/BUILD/skell-1.19

rpmbuild --dbpath
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/rootfs//var/lib/rpm
--target arm --define '_unpackaged_files_terminate_build 0' --define
'_target_cpu arm' --define '__strip strip' --define '_topdir
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/rpm'
--define '_prefix /usr' --define '_tmppath
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/tmp'
--define '_rpmdir
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/rpm/RPMS'
 
--define '_mandir /usr/share/man' --define '_sysconfdir /etc' --define
'_localstatedir /var' -bb --clean --rmsource 
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/dist/lfs-5.1/skell/skell-omap_logic.spec
Building target platforms: arm
Building for target arm
Executing(%prep): /bin/sh -e
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/tmp/rpm-tmp.63989
+ umask 022
+ cd
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/rpm/BUILD
+ cd
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/rpm/BUILD
+ rm -rf skell-1.19
+ tar -xvvf -
+ /bin/gzip -dc
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/rpm/SOURCES/skell-1.19.tar.gz

...


And if %allow_clobber is not set I get:

address@hidden:~/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0$
./ltib --clobber -p skell

Processing platform: Logic OMAP3530/03&DM3730/03 reference boards
===================================================================
using config/platform/omap_logic/.config

Processing: skell-omap_logic
==============================
Build path taken because: directory build, no prebuilt rpm,

Package skell-omap_logic specfile is updated but package build source
exists.
--clobber specified but %allow_clobber not enabled in .ltibrc;
Cowardly refusing to to clobber existing build source:
 
/home/peter/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-3.0/rpm/BUILD/skell-1.19
Enable %allow_clobber in .ltibrc if you really want to automatically remove
package build source if specfile is updated

scbuild/scdeploy already unpacked package

Processing: skell-omap_logic
==============================
Build path taken because: directory build, build key set, no prebuilt rpm,

Mike, can you try this patch to see if it works in your continuous
integration server?  Note that the patch does *note* enable
%allow_clobber in .ltibrc; you need to uncomment %allow_clobber (and the
value following it) *and* set the value to non-zero.

-- 
Peter Barada
address@hidden

ltib-clobber-v2.patch
Description: Text Data