[LTIB] LPC3250: Some mistakes(maybe) in lpc32xx_init

ltib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[LTIB] LPC3250: Some mistakes(maybe) in lpc32xx_init_irq(void)

From:	Li Yuan-Lung
Subject:	[LTIB] LPC3250: Some mistakes(maybe) in lpc32xx_init_irq(void)
Date:	Tue, 25 Jan 2011 13:57:06 +0800

Dear Kevin,
Forgot to tell you that I just found this strange code in IRQ init of lpc32xx series last month.
In void __init lpc32xx_init_irq(void), please kindly see the attachment.

The "MIC_APR_DEFAULT" and "MIC_ATR_DEFAULT" was used in SIC1 and SIC2 init. I also see "SIC1_ATR_DEFAULT" and "SIC2_ATR_DEFAULT" defined but never been referenced. I didn't check detail meaning of each bit. I guess this migh be the copy-paste typo.

--
Best Regards,

Henry Li
SW Engineer of Climax Co.
TEL: +886-2-2794-0001 ext.231
FAX: +886-2-2792-6618

Mistake_irq_init.PNG
Description: PNG image

[Prev in Thread]

Current Thread

[Next in Thread]

[LTIB] LPC3250: Some mistakes(maybe) in lpc32xx_init_irq(void), Li Yuan-Lung <=
- RE: [LTIB] LPC3250: Some mistakes(maybe) in lpc32xx_init_irq(void), Kevin Wells, 2011/01/25

Prev by Date: [Ltib] Build results for 20110124
Next by Date: [Ltib] error getting 'http://bitshrine.org/gpp//-4.0.4.tar.gz'
Previous by thread: [Ltib] Build results for 20110124
Next by thread: RE: [LTIB] LPC3250: Some mistakes(maybe) in lpc32xx_init_irq(void)
Index(es):
- Date
- Thread