Re: [Ltib] RE: [PATCH] Change trigger to packages with suffix _MOD

[Stuart Hughes]

Hi Olivia,

I don't really understand this.  Can you give/explain a use case (bug 
case) showing why you needed to do this.  Was this in single package 
mode or when running ./ltib?  The flag $cf->{leavesrc} is only for a 
single package, so I don't quite get this.

Regards, Stuart

Yin Olivia-R63875 wrote:
> Hi Stuart,
>
> Since transient config has been cleaned, 'PKG_KERNEL_LEAVESRC=y' in
> defconfig will be changed into '# PKG_KERNEL_LEAVESRC is not set' in
> .config
> But the packages with suffix _MOD's build key is set as 1.
> If we run ./ltib without any configuration changes, the packages with
> suffix _MOD will not find the built unpacked kernel source tree.
>
> I think the module packages don't need force rebuild unless the kernel
> rebuilt and the kernel source tree left.
>
> Best Regards,
> Olivia
>
> > Signed-off-by: Olivia Yin <address@hidden>
> > ---
> >  ltib |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ltib b/ltib
> > index 7dcf730..1dce7d3 100755
> > --- a/ltib
> > +++ b/ltib
> > @@ -1723,8 +1723,8 @@ sub process_pkg_triggers
> >              if(exists $$mod->{was_en} && $$mod->{was_en}) {
> >                  $$mod->{en} = 1;
> >              }
> > -            $$mod->{build} = 1;
> > -            warn "$$mod->{sn} rebuild forced by $$key->{sn}\n" if
> $$mod->{en};
> > +            $$mod->{build} = 1 if $$key->{build} && $cf->{leavesrc};
> > +            warn "$$mod->{sn} rebuild forced by $$key->{sn}\n" if
> $$mod->{build};
> >          }
> >      }
> >      foreach my $dep ( @{$install_deps->{$key}} ) {
> > --
> > 1.6.4
>
>
> _______________________________________________
> LTIB home page: http://ltib.org
>
> Ltib mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/ltib