Re: [lmi] [lmi-commits] master d5023a75: Update premium-tax rates

[Vadim Zeitlin]

On Wed, 26 Apr 2023 09:05:15 -0400 (EDT) Greg Chicares 
<gchicares@sbcglobal.net> wrote:

GC> branch: master
GC> commit d5023a7581279851073cf18da1ed9648c6a2af42
GC> Author: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> 
GC>     Update premium-tax rates

 Hello,

 Just in case you're not aware of it, this change has broken the unit
tests, e.g. looking at

https://github.com/let-me-illustrate/lmi/actions/runs/4809456244/jobs/8560728611

you can see the following output

---------------------------------- >8 --------------------------------------
FAIL: premium_tax_test
======================

'Let me illustrate...' creates life insurance illustrations.

Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005,
2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015,
2016, 2017, 2018, 2019, 2020, 2021, 2022, 2023 Gregory W. Chicares.

This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
version 2 as published by the Free Software Foundation.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software Foundation,
Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA



???? test failed:   '0.015' == '0.0175'
[file ../premium_tax_test.cpp, line 67]

???? test failed:   '0.015' == '0.0175'
[file ../premium_tax_test.cpp, line 68]

???? test failed:   '0.015' == '0.0175'
[file ../premium_tax_test.cpp, line 69]

???? test failed:   '0.015' == '0.0175'
[file ../premium_tax_test.cpp, line 70]

???? test failed:   '0.015' == '0.0175'
[file ../premium_tax_test.cpp, line 72]

???? 5 test errors detected; 25 tests succeeded


???? returning with error code 201

???? 
???? errors detected; see stdout for details
FAIL premium_tax_test (exit status: 201)
---------------------------------- >8 --------------------------------------

 Annoyingly (I had complained about this many times in the past, so I won't
do it again, but it still seems very wrong to me), the test suite "passes",
i.e. returns 0 exit code, for the make-based builds, but the tests still
fail there, e.g. the Linux/make/gcc job at
https://github.com/let-me-illustrate/lmi/actions/runs/4809456244/jobs/8560728047

---------------------------------- >8 --------------------------------------
???? errors detected; see stdout for details
make[2]: [/__w/lmi/lmi/workhorse.make:805: premium_tax_test-run] Error 201 
(ignored)

Running premium_tax_test:

???? test failed:   '0.015' == '0.0175'
[file /__w/lmi/lmi/premium_tax_test.cpp, line 67]

???? test failed:   '0.015' == '0.0175'
[file /__w/lmi/lmi/premium_tax_test.cpp, line 68]

???? test failed:   '0.015' == '0.0175'
[file /__w/lmi/lmi/premium_tax_test.cpp, line 69]

???? test failed:   '0.015' == '0.0175'
[file /__w/lmi/lmi/premium_tax_test.cpp, line 70]

???? test failed:   '0.015' == '0.0175'
[file /__w/lmi/lmi/premium_tax_test.cpp, line 72]

???? 5 test errors detected; 25 tests succeeded


???? returning with error code 201
---------------------------------- >8 --------------------------------------

 Please let me know if I should do anything about this or if this new
failure should be just ignored.

 Thanks,
VZ

pgpHTUKfCN01Y.pgp
Description: PGP signature