Re: [lmi] Adapting to wine-8

[Vadim Zeitlin]

On Mon, 23 Jan 2023 14:13:27 +0100 I wrote:

Me>  I'm going to look into NtUserScrollWindowEx message because it seems
Me> suspicious to me that we use ScrollWindow() with some flags unusual enough
Me> to be unsupported by Wine, so I'd like to make sure there is no bug in wx
Me> here.

 I can now confirm that there is no bug in wx, but I think there is a bug
in Wine as a relatively recent refactoring results in ScrollWindow()
function calling NtUserScrollWindowEx() with invalid flags, see
https://bugs.winehq.org/show_bug.cgi?id=54357

VZ> And nodrv_CreateWindow could probably be avoided by just launching
VZ> Xvfb earlier, so I think I might do this just because it doesn't cost much.

 And I can also confirm this, i.e. these warnings don't appear in the CI
logs any longer after moving the step launching Xvfb up.

VZ> But the rest of the messages seems to be about some internal Wine stuff
VZ> that we don't really care about and so could be suppressed and I'll do it
VZ> just to clean things up a little.

 On further thought, perhaps it's better to leave them because WINEDEBUG
mechanism is too coarse. E.g. we're definitely not interested in the
messages such as

03c4:fixme:shell:SHAutoComplete stub

because this just means that SHAutoComplete() is not implemented (which it
isn't), but I don't want to suppress all fixme messages from the shell
component just in case some more interesting/important ones appear in the
future. Similarly,

03c4:fixme:event:wait_for_withdrawn_state window 0x60400/a0007a wait timed out

doesn't look like something we could possibly do anything about, but it's
not a reason to ignore all the event-related messages.

 So I'm just going to push the trivial changes of
https://github.com/let-me-illustrate/lmi/pull/225 that suppress HID and IMM
messages (as I don't think we're going to ever run into any real problems
with these components) in WINEDEBUG and leave the rest enabled.

 Of course, please let me know if you have any objections (and this is
obviously not urgent at all).

 Regards,
VZ

pgpDjgQ26kfjb.pgp
Description: PGP signature