[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] [lmi-commits] odd/rules_of_n eb5fef08 4/5: Follow the Rule of
From: |
Greg Chicares |
Subject: |
Re: [lmi] [lmi-commits] odd/rules_of_n eb5fef08 4/5: Follow the Rule of Five |
Date: |
Sun, 10 Jul 2022 17:10:35 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 7/10/22 12:11, Vadim Zeitlin wrote:
> On Sat, 9 Jul 2022 18:31:24 -0400 (EDT) Greg Chicares
> <gchicares@sbcglobal.net> wrote:
[...]
> GC> For concinnity, written thus:
> GC> - all ctors
> GC> - blank line
> GC> - the other five special members, in a consistent order
> GC> - blank line
>
> I think it would be more clear if the first line of the paragraph above
> said "All ctors except for the copy and move ctors".
Amended accordingly. Thanks.
> GC> All added special members are defaulted, except that they're deleted
> GC> for class any_entity. Perhaps they should all be deleted, initially at
> GC> least, and defaulted only if they're used.
>
> This is definitely a good idea in general, but I'm pretty sure at least
> some of the copy ctors are actually used and there would be a lot of
> compilation errors if you deleted them.
I think I'll get this branch merged, modulo mistakes such as
the one above, and then s/= default/= delete/ where possible.