Re: [lmi] "Unknown accel modifier: 'Num'"

[Vadim Zeitlin]

On Sun, 3 Jul 2022 01:33:33 +0000 Greg Chicares <gchicares@sbcglobal.net> wrote:

GC> To reproduce:
GC>   wine ./lmi_wx_shared.exe --ash_nazg --data_path=/opt/lmi/data
GC>   File | New | Census
GC> There's no messagebox, so end users won't see anything, but
GC> on the console this appears:
GC>   Unknown accel modifier: 'Num'
GC> presumably because of:
GC>   menus.xrc:            <accel>Ctrl-Num-+</accel>
GC>   menus.xrc:            <accel>Ctrl-Num--</accel>
GC> This occurs during the automated GUI test, which however succeeds.

 I'm really sorry about this, I have no idea how did it happen, but it
seems that I've somehow failed to amend the commit 2892d588a (Add extra
accelerators with "+" and "-" keys synonyms, 2022-06-05) as I was sure to
have done because I had seen exactly the same errors when testing it and
fixed them by applying this trivial patch:

---------------------------------- >8 --------------------------------------
diff --git a/menus.xrc b/menus.xrc
index b330c32b0..f0a9c1714 100644
--- a/menus.xrc
+++ b/menus.xrc
@@ -388,7 +388,7 @@
         <label>_Add cell\tCtrl-+</label>
         <extra-accels>
             <accel>Shift-Ctrl-+</accel>
-            <accel>Ctrl-Num-+</accel>
+            <accel>Ctrl-Num +</accel>
         </extra-accels>
         <bitmap platform="win" stock_id="insert-rows"/>
         <help>Add a new cell with case default parameters</help>
@@ -397,7 +397,7 @@
         <label>_Delete cell(s)\tCtrl--</label>
         <extra-accels>
             <accel>Shift-Ctrl--</accel>
-            <accel>Ctrl-Num--</accel>
+            <accel>Ctrl-Num -</accel>
         </extra-accels>
         <bitmap platform="win" stock_id="delete-row"/>
         <help>Delete selected cell(s)</help>
---------------------------------- >8 --------------------------------------

 Unfortunately, this change has somehow disappeared from the branch I've
submitted, certainly due to my own mistake, but I don't even know what did
I do wrong.

 In any case, the patch above is necessary not only to avoid the messages
above, but also in order to make the accelerators work. And it makes sense
because "Num" is not a modifier, like "Ctrl" or "Shift", but rather "Num +"
is the name of the key.

 Sorry again about this omission and thanks for noticing it!
VZ

pgp1YeRFet0jy.pgp
Description: PGP signature