Re: [lmi] Should we update libxml and its kin?

[Greg Chicares]

On 2022-03-10 15:59, Vadim Zeitlin wrote:
[...]
>  I've created https://github.com/let-me-illustrate/lmi/pull/200

Could something in this changeset have broken the build?

In a recently-created 'bookworm' chroot, I applied this changeset,
then ran './install_msw.sh', hoping that everything would rebuild.
But I encountered this problem with libxslt:

checking for x86_64-pc-linux-gnu-xml2-config... no
checking for xml2-config... 
/opt/lmi/local/gcc_x86_64-pc-linux-gnu/bin/xml2-config
checking for libxml libraries >= 2.6.27... 2.9.13 found
checking whether shared libraries will be built (required for plugins)... yes
checking libxml2 module support... no
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating libxslt.pc
config.status: creating libexslt.pc
config.status: creating libxslt/Makefile
config.status: creating libxslt/xsltconfig.h
config.status: error: cannot find input file: `libxslt/xsltwin32config.h.in'
+ err=1
+ [ -n 1 ]
+ echo *** Configuring failed, contents of config.log follows: ***
*** Configuring failed, contents of config.log follows: ***

Is some extra step needed to create 'libxslt/xsltwin32config.h.in'?

This seemed reminiscent of...
  https://lists.nongnu.org/archive/html/lmi/2021-10/msg00023.html
which was a failure to update submodules; that historical problem
was cured by pushing everything, but today I reran './install_msw.sh'
after pushing everything, and pushing didn't resolve the problem.
The XML and XSLT submodules seem to have the SHA1s you intend:

/opt/lmi/src/lmi[0]$git submodule status     
 8d06ccd47959e3fd10e49ebb7582d73c5fc9f1dd third_party/libxml2 
(remotes/origin/lmi)
 a8edc9ab71093db3267f2b3b905aa8c465c6c363 third_party/libxslt 
(remotes/origin/lmi)
 efd7bf881e9b5fceca6ceaf1edba072a56de971b third_party/wx (v3.1.4-4-gefd7bf881e)
 1839b231c5138edd40b752272631e2f1d5311456 third_party/wxpdfdoc 
(v0.9.8-13-g1839b23)
 efb0542106cee71ab17caae1f9b77ed7a56a6eb4 third_party/xmlwrapp 
(v0.9.0-53-gefb0542)

and those SHA1s aren't affected by an explicit update:

/opt/lmi/src/lmi[0]$git submodule update
/opt/lmi/src/lmi[0]$git submodule status
 8d06ccd47959e3fd10e49ebb7582d73c5fc9f1dd third_party/libxml2 
(remotes/origin/lmi)
 a8edc9ab71093db3267f2b3b905aa8c465c6c363 third_party/libxslt 
(remotes/origin/lmi)
 efd7bf881e9b5fceca6ceaf1edba072a56de971b third_party/wx (v3.1.4-4-gefd7bf881e)
 1839b231c5138edd40b752272631e2f1d5311456 third_party/wxpdfdoc 
(v0.9.8-13-g1839b23)
 efb0542106cee71ab17caae1f9b77ed7a56a6eb4 third_party/xmlwrapp 
(v0.9.0-53-gefb0542)

Still, git-status is unclean...

/opt/lmi/src/lmi[0]$git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)
        modified:   third_party/libxml2 (untracked content)

no changes added to commit (use "git add" and/or "git commit -a")

...so it does look like I've applied something incorrectly.

Delving further into the history, I find
  https://lists.nongnu.org/archive/html/lmi/2021-10/msg00022.html
from which I gather that I must update submodules explicitly.
I thought 'git submodule update' above was explicit enough, but
I tried making it even more explicit by naming the submodules:

/opt/lmi/src/lmi[0]$git submodule update third_party/libxml2 
/opt/lmi/src/lmi[0]$git submodule update third_party/libxslt 

...with no apparent effect...

/opt/lmi/src/lmi[0]$git submodule status
 8d06ccd47959e3fd10e49ebb7582d73c5fc9f1dd third_party/libxml2 
(remotes/origin/lmi)
 a8edc9ab71093db3267f2b3b905aa8c465c6c363 third_party/libxslt 
(remotes/origin/lmi)
 efd7bf881e9b5fceca6ceaf1edba072a56de971b third_party/wx (v3.1.4-4-gefd7bf881e)
 1839b231c5138edd40b752272631e2f1d5311456 third_party/wxpdfdoc 
(v0.9.8-13-g1839b23)
 efb0542106cee71ab17caae1f9b77ed7a56a6eb4 third_party/xmlwrapp 
(v0.9.0-53-gefb0542)

/opt/lmi/src/lmi[0]$git status          
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)
        modified:   third_party/libxml2 (untracked content)

What am I missing?

I can attach
  /opt/lmi/local/gcc_x86_64-pc-linux-gnu/xml-ad_hoc/libxslt/config.log
in its entirety if that would be helpful, but I think this is a
git problem, not a libxslt one.