Re: [lmi] [lmi-commits] master 111dd8d 1/5: Link exception unwinder in auxiliary programs

[Vadim Zeitlin]

On Sun, 18 Jul 2021 08:13:54 -0400 (EDT) Greg Chicares 
<gchicares@sbcglobal.net> wrote:

GC> branch: master
GC> commit 111dd8d5e3e61f80e0e07cd297c23bfed42261b2
GC> Author: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> 
GC>     Link exception unwinder in auxiliary programs
GC>     
GC>     'Makefile.am' needs no such modification because it links 'liblmi'
GC>     rather than selected objects.

 Sorry, this is not quite correct because test_coding_rules target doesn't
link with liblmi, but just with libmain_auxiliary_common, so this change
broke it, see

        https://github.com/let-me-illustrate/lmi/actions/runs/1042434912

 The simplest possible fix is just
---------------------------------- >8 --------------------------------------
diff --git a/Makefile.am b/Makefile.am
index de4c393b8..610f40e00 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -583,7 +583,8 @@ test_coding_rules_SOURCES = \
   miscellany.cpp \
   my_test_coding_rules.cpp \
   sigfpe.cpp \
-  test_coding_rules.cpp
+  test_coding_rules.cpp \
+  unwind.cpp
 test_coding_rules_CXXFLAGS = $(AM_CXXFLAGS) $(BOOST_INCLUDE_FLAGS)
 test_coding_rules_LDADD = \
   libmain_auxiliary_common.la \
---------------------------------- >8 --------------------------------------

but to follow this commit changes I guess I should rather change
libmain_auxiliary_common, i.e. do this:

---------------------------------- >8 --------------------------------------
diff --git a/Makefile.am b/Makefile.am
index de4c393b8..cc2461277 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -399,7 +399,8 @@ libmain_auxiliary_common_la_SOURCES = \
     fenv_lmi.cpp \
     main_common.cpp \
     main_common_non_wx.cpp \
-    sigfpe.cpp
+    sigfpe.cpp \
+    unwind.cpp

 # Note: apparently useless setting of target_CXXFLAGS to its default value of
 # AM_CXXFLAGS is required for its side effect, as doing this forces automake to
---------------------------------- >8 --------------------------------------

 Would you mind if I push this change?

 Thanks,
VZ

pgpgfNwRMpOtg.pgp
Description: PGP signature