[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] PATCH: Switch to using std::filesystem
|
From: |
Greg Chicares |
|
Subject: |
Re: [lmi] PATCH: Switch to using std::filesystem |
|
Date: |
Thu, 29 Apr 2021 02:33:07 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 |
On 4/26/21 9:53 PM, Vadim Zeitlin wrote:
[...]
> The rest of the changes just deal with the differences between the two
> libraries. They're done in different commits to make it simpler to review
> them, but should, for once, be applied all together, i.e. the entire PR
> should be "squash merged", as almost all of these commits are needed for
> the code to actually compile and work, and preserving their history is not
> very important.
OTOH, is squashing very important? Do you have a strong
preference for me to squash this into a single commit?
Would you object if it enters origin/master as thirty-four
distinct commits?