Re: [lmi] [lmi-commits] master 2acf385 4/4: Let "PolicyForm" vary by state for product 'sample'

[Greg Chicares]

On 11/14/20 4:00 PM, Vadim Zeitlin wrote:
> On Sat, 14 Nov 2020 10:24:45 -0500 (EST) Greg Chicares 
> <gchicares@sbcglobal.net> wrote:
[...]
> GC>          PolicyForm = p.datum(alt_form ? "PolicyFormAlternative" : 
> "PolicyForm");
> GC> +
> GC> +        if("sample" == b->yare_input_.ProductName)
> GC> +            {
> GC> +            auto policy_form = b->database().query<int>(DB_PolicyForm);
> GC> +            LMI_ASSERT(b->lingo_->lookup(policy_form) == PolicyForm);
> GC> +            PolicyForm = b->lingo_->lookup(policy_form);
> GC> +            }
> GC> +
> 
>  Sorry, but after looking it for quite some time, I still can't understand
> the purpose of this code, so I'd like to ask: is it just a temporary
> debugging check or is there something I'm missing here?

Yes, it's just a temporary debugging check.

First, I'll change a lot of (mostly proprietary) code so that the
assertion will be true for all products; then I'll remove the "if"
conditional; then, after a thorough test, I'll remove the assertion;
and then I'll get rid of product_data::PolicyForm and
product_data::PolicyFormAlternative, as well as the code that
supports 'alt_form' above.

Later, I'll treat most data members of class product_data the way
I'm treating PolicyForm.

It's a large amount of exacting but tedious work.