Re: [lmi] Question about using fardels

[Greg Chicares]

On 2020-09-22 16:40, Vadim Zeitlin wrote:
> On Tue, 22 Sep 2020 02:28:09 +0000 Greg Chicares <gchicares@sbcglobal.net> 
> wrote:
> 
> GC> On 2020-09-21 21:53, Vadim Zeitlin wrote:
[...]
> GC> >         % ./lmi_cli_shared.exe --accept --data_path=. --selftest
> GC> >         Value 'sample2naic' invalid for type 'ce_product_name'.
> GC> >         [ce_product_name.cpp : 145]
[...]
> GC> Wait...the message really means what it says, once you see
> GC> what it means: there are no 'sample2naic' product files on
> GC> the data path.
> 
>  Could I timidly suggest that reformulating this error message as "product
> files for product 'sample2naic' not found" could be helpful?

This sounds like a simple and obvious change, but OTOH:
 (1) this is the first time it's ever been reported;
 (2) there are several other
       << "' invalid for type '"
     messages, and it seems wrong to change only one; and
 (3) it looks like there's a unit test that would need to
     be changed too, at the cost of one iota more labor;
so after changing it locally, I noticed (3), then stepped
back and thought again; then, when I realized (2), I
undid the local change.

> GC> Thanks for reporting this defect.

[i.e., that the 'sample2*' files used by '--selftest' were missing]

>  Encouraged by your thanks (no good deed goes unpunished...) I'd like to
> report that a few more files seem to be missing from fardels:
> 
> - company_logo.png and group_quote_banner.png: I think those should be
>   included, as there really doesn't seem any reason not to, and this would
>   make lmi user-friendlier as everybody likes dogs.
> 
> - configurable_settings.xml: I'm less sure about this one, but the fact is
>   that it must be created before doing anything with lmi.

All three of those files are in my fardels, because of this
in 'workhorse.make':

wrap_fardel:
        @$(INSTALL) -m 0664 $(datadir)/configurable_settings.xml .
        @$(INSTALL) -m 0664 $(datadir)/company_logo.png .
        @$(INSTALL) -m 0664 $(datadir)/group_quote_banner.png .

I believe 'make install', which is a prerequisite of 'fardel',
should have installed those three files to $datadir. Any idea
where this went wrong?

> - This is a negatively missing file: I wonder if wx_test.exe should be
>   included in the fardel? It's a relatively big (I wonder why is it so
>   big, in fact...) file which isn't necessary for using lmi and other
>   tests are not included, so why is this one?

I can't recall ever running that in a fardel. And we wouldn't
normally create a fardel without testing everything (including
this GUI test) first, so probably it is unnecessary. But let
me ask Kim first before removing it (and lmi_md5sum.exe, which
I think needn't be distributed).