[lmi] wxPdf-dependent gcc warnings [Was: wx-dependent gcc warnings]

[Greg Chicares]

On 2020-06-09 11:41, Greg Chicares wrote:
> On 2020-06-08 23:14, Greg Chicares wrote:
> [...]
>> And of course it's easy to find all diagnostics that are inhibited
>> by '-isystem' for wx, by moving one line:

Similarly, for wxPdf, rebuilding with

----*<----
diff --git a/workhorse.make b/workhorse.make
index bfef423c..ba4afdaa 100644
--- a/workhorse.make
+++ b/workhorse.make
@@ -299,14 +299,14 @@ lmi_include_directories := \
   $(srcdir) \
   $(srcdir)/tools/pete-2.1.1 \
   $(overriding_include_directories) \
+  $(localincludedir) \
+  $(localincludedir)/libxml2 \
 
 sys_include_directories := \
   $(compiler_include_directory) \
   $(wx_include_paths) \
   /opt/lmi/third_party/include \
   /opt/lmi/third_party/src \
-  $(localincludedir) \
-  $(localincludedir)/libxml2 \
 
 all_source_directories := \
   $(srcdir) \
---->*----

leads to:

<errors.txt grep 'Werror=' |sed -e's/^.*Werror=//' |sort | uniq -c      
     72 extra-semi]
    171 suggest-override]

Certainly all the extra-semi issues can be resolved, and if it's
also possible to replace 'virtual' with 'override', then the wxPdf
headers can be included with '-I' rather than '-isystem', without
producing any diagnostics in lmi (tested with gcc-8.3 only).