[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] Fardel and $compiler_runtime_files
From: |
Greg Chicares |
Subject: |
Re: [lmi] Fardel and $compiler_runtime_files |
Date: |
Tue, 28 May 2019 00:55:27 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 2019-05-27 22:35, Vadim Zeitlin wrote:
>
> Testing fardel distribution with the new home-brewed md5sum.exe we've
> discovered that it doesn't run from the fardel because it references the
> compiler runtime DLLs (libstdc++-6.dll and libgcc_s_sjlj-1.dll) that are
> not present in the fardel.
Those DLLs are in my older fardels, but I just made another, and
they are indeed missing. Thanks for finding this.
> IMO this is a defect because lmi binaries depend on these DLLs as well and
> so not including them in the fardel makes it not self-contained. Fixing
> this would be as simple as adding $(wildcard $(bindir)/*$(SHREXT)) to
> fardel_binaries, but I wonder how could this have gone unnoticed before and
> if there is something I'm missing here? And if not, would you like me to
> make a PR for this change or do you prefer to just make it directly?
First, I want to investigate how I made this mistake. Second, I'll
look for collateral mistakes. Then I'll fix it. You needn't do
anything further.