Re: [lmi] [lmi-commits] master aee9f4d 10/11: For cygwin, add msw system directory to minimal path

[Vadim Zeitlin]

On Wed,  8 May 2019 13:23:25 -0400 (EDT) Greg Chicares <address@hidden> wrote:

GC> branch: master
GC> commit aee9f4df39f44582f47d8fc1355f5051c46bff07
GC> Author: Gregory W. Chicares <address@hidden>
GC> Commit: Gregory W. Chicares <address@hidden>
GC> 
GC>     For cygwin, add msw system directory to minimal path
GC>     
GC>     Without this, 'cmd.exe' and 'java.exe' cannot be found.
GC> ---
GC>  install_msw.sh | 7 +++++++
GC>  1 file changed, 7 insertions(+)
GC> 
GC> diff --git a/install_msw.sh b/install_msw.sh
GC> index 0bf41f5..513da8e 100755
GC> --- a/install_msw.sh
GC> +++ b/install_msw.sh
GC> @@ -37,6 +37,13 @@ echo "Started: $stamp0"
GC>  # This should work with a rather minimal path.
GC>  
GC>  minimal_path=${MINIMAL_PATH:-"/usr/bin:/bin:/usr/sbin:/sbin"}
GC> +
GC> +case "$lmi_build_type" in
GC> +    (*-*-cygwin*)
GC> +        minimal_path="$minimal_path:/cygdrive/c/Windows/system32"
GC> +        ;;
GC> +esac

 This is probably never going to be a concern in practice, but the above
doesn't work on my machine as the path c:\Windows\system32 doesn't exist
here (the OS is installed on a different drive, mostly in order to detect
broken programs that hardcode c: as the OS drive).

 Using `cygpath -u "$WINDIR\\system32"` (or the same thing with
$SYSTEMROOT) should work anywhere and wouldn't require much more work
however.

 Regards,
VZ