Re: [lmi] Logo on group quotes but not illustrations

[Greg Chicares]

On 2018-08-09 12:32, Vadim Zeitlin wrote:
> On Thu, 9 Aug 2018 12:21:32 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> I see no logo whatsoever, on any page.
> 
>  I'm sorry, I don't know what's going on here. Could you perhaps remove the
> "wxLogNull" line from ledger_pdf_generator_wx.cpp to see if you get any
> errors when trying to load the image?

Thanks. Now it's fixed. I see:

12:50:53: can't open file 'Z:/opt/lmi/data/company_logo.png' (error 2: File not 
found.)
12:50:53: Failed to load image from file "Z:/opt/lmi/data/company_logo.png".

[repeats sixteen times]

I think I'll change the code so that it handles failure there in the
same way that it handles failure to load a similar file elsewhere:
i.e., showing an explicit diagnostic.

$ls /opt/lmi/bin/company_logo*                            
/opt/lmi/bin/company_logo.jpg  /opt/lmi/bin/company_logo.png
$ls /opt/lmi/data/company_logo*                          
zsh: no matches found: /opt/lmi/data/company_logo*

All graphics files reside in data/ except these:

/opt/lmi/src/lmi[0]$ls /opt/lmi/bin/*.png       
/opt/lmi/bin/company_logo.png  /opt/lmi/bin/group_quote_banner.png
/opt/lmi/src/lmi[0]$ls /opt/lmi/data/*.png |wc -l
109

I don't know why these two are exceptions; maybe it was due to
some XSL-FO weirdness. Probably we should put them in data/ only:
  $mv /opt/lmi/bin/*.png /opt/lmi/data
and make any necessary adjustments (ignoring XSL-FO) to make that
work. And indeed now that I've run that 'mv' command, illustrations
show the glorious 22.II-16.III.1966 logo on every page...except,
with 'sample2ipp', for the "continuation" page that begins "It was
a voluptuous scene, that masquerade" (which you want to fix, though
I'm not sure that's a prerequisite for pulling the plug on XSL-FO),
and, curiously, for the "cover page", which has a logo for other
ledger types, but not this one (most likely because the original
XSLT behaved that way).