Re: [lmi] Preserving configurable settings after GUI test

[Vadim Zeitlin]

On Mon, 30 Jul 2018 14:36:34 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2018-07-29 16:42, Vadim Zeitlin wrote:
GC> [...]
GC> >  I wanted to wait until the PR 88 would be dealt with before submitting 
the
GC> > next one but, finally, there doesn't seem to be any real point in doing 
it,
GC> > so I've created https://github.com/vadz/lmi/pull/89
GC> PR 89 committed, unchanged--thanks.

 Thanks for applying it!

GC> As for PR 88, I've committed something simpler--sorry, I should have
GC> realized that what I originally asked for was a lot bigger than what
GC> we really need.

 Well, I did have my doubts about it, but finally decided it was better to
be thorough for the reasons I explained in the commit message. Maybe I was
too much so, but I still think your changes go too far in the other
direction as they don't even restore the file in the case of test failure.
I.e. if nothing else, I'd at least use RAII/scope guard/explicit try/catch
to ensure that the 2 settings we want to preserve here are indeed preserved
in this case. Would you consider doing it/applying a patch from me doing it
or do you think this would be overkill as well?

VZ