Re: [lmi] [lmi-commits] master d0bb8a0 2/6: Add some apparently-missing CXX flags

[Greg Chicares]

On 2018-07-26 11:35, Vadim Zeitlin wrote:
> On Wed, 25 Jul 2018 21:11:31 -0400 (EDT) Greg Chicares <address@hidden> wrote:
> 
> GC> branch: master
> GC> commit d0bb8a0662d9ef9fe5873e0d1f6de8075c21d715
[...]
> GC>     Add some apparently-missing CXX flags
[...]
> GC> +test_interpolate_string_CXXFLAGS = $(AM_CXXFLAGS)
[...]
> GC> +test_rate_table_CXXFLAGS = $(AM_CXXFLAGS)
[...]
>  This is not really important but, just to understand what's going on, what
> problem exactly does the above change solve?

Glaring inconsistency. Formerly, fifty-eight out of sixty tests
that use only the default AM_CXXFLAGS specified that explicitly:
  test_NameOfTest_CXXFLAGS = $(AM_CXXFLAGS)
and now sixty out of sixty do.

> It's my understanding that
> AM_CXXFLAGS is used by default if ${target}_CXXFLAGS is not defined, see
> 
> https://www.gnu.org/software/automake/manual/html_node/Program-Variables.html

I guessed that that was probably the case, but to make sure of
it would have taken me much more time than it took to remove
the two inconsistencies.

> And if I'm right about this, adding the above lines should basically have
> no effect whatsoever. Of course, I could be wrong, but doing
> 
>       $ make -n interpolate_string_test.o AM_CXXFLAGS=FOOBAR
> 
> (without the change above), the command that would be executed looks all
> right to me, i.e. it does show "FOOBAR" in it.
> 
>  So perhaps this change is really unnecessary, after all?

We could instead remove all the feckless flags, e.g.:
- test_account_value_CXXFLAGS = $(AM_CXXFLAGS)
- test_actuarial_table_CXXFLAGS = $(AM_CXXFLAGS)
- test_alert_CXXFLAGS = $(AM_CXXFLAGS)
- test_any_member_CXXFLAGS = $(AM_CXXFLAGS)
- test_assert_lmi_CXXFLAGS = $(AM_CXXFLAGS)
- test_authenticity_CXXFLAGS = $(AM_CXXFLAGS)
... and that's just the tests beginning with the letter 'a'.