[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] First version of the illustrations pagination patch
From: |
Greg Chicares |
Subject: |
Re: [lmi] First version of the illustrations pagination patch |
Date: |
Wed, 18 Jul 2018 22:21:08 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-07-18 15:17, Greg Chicares wrote:
> On 2018-07-18 12:16, Greg Chicares wrote:
>> On 2018-07-17 21:14, Greg Chicares wrote:
>>
> [...steps to reproduce...]
>>
>> Not enough space for all 10 columns.
> [...]
>> Assertion '0 <= ci.col_width - column_margin()' failed.
[...]
> I rolled back the last nine of the thirteen commits in this PR...
[...]
> /opt/lmi/src/lmi[0]$git checkout d1b03aa0
[...]
> ..and rebuilt, after which I observed neither the problems above,
> nor the one below
Those errors reappear if I roll back only eight of the commits:
git checkout b515441b
They do go away with this brute-force change:
---------8<--------8<--------8<--------8<--------8<--------8<--------8<-------
diff --git a/group_quote_pdf_gen_wx.cpp b/group_quote_pdf_gen_wx.cpp
index 95372c93..289de90b 100644
--- a/group_quote_pdf_gen_wx.cpp
+++ b/group_quote_pdf_gen_wx.cpp
@@ -666,7 +666,7 @@ void group_quote_pdf_generator_wx::save(std::string const&
output_filename)
pdf_writer_wx pdf_writer
(output_filename
,wxLANDSCAPE
- ,{7, 8, 10, 12, 14, 17, 20} // Standard HTML font sizes.
+ ,{7, 7, 7, 7, 7, 7, 7} // Standard HTML font sizes.
);
int pos_y = 0;
--------->8-------->8-------->8-------->8-------->8-------->8-------->8-------
but I don't see what the problem was. Searching online for
"Standard HTML font sizes" produces such a chorus of "Use CSS!"
that I'd almost think HTML3 predated the web.
- Re: [lmi] First version of the illustrations pagination patch, Greg Chicares, 2018/07/12
- Re: [lmi] First version of the illustrations pagination patch, Vadim Zeitlin, 2018/07/13
- Re: [lmi] First version of the illustrations pagination patch, Greg Chicares, 2018/07/13
- Re: [lmi] First version of the illustrations pagination patch, Vadim Zeitlin, 2018/07/14
- Re: [lmi] First version of the illustrations pagination patch, Greg Chicares, 2018/07/14
- Re: [lmi] First version of the illustrations pagination patch, Vadim Zeitlin, 2018/07/14
- Re: [lmi] First version of the illustrations pagination patch, Greg Chicares, 2018/07/17
- Re: [lmi] First version of the illustrations pagination patch, Vadim Zeitlin, 2018/07/17
Re: [lmi] First version of the illustrations pagination patch, Vadim Zeitlin, 2018/07/21