Re: [lmi] libstdc++ in gcc-7.3.0: std::vector<incomplete_type>

[Vadim Zeitlin]

On Wed, 25 Apr 2018 00:45:58 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2018-04-24 21:20, Vadim Zeitlin wrote:
GC> > On Tue, 24 Apr 2018 20:14:10 +0000 Greg Chicares <address@hidden> wrote:
GC> > 
GC> > GC> On 2018-04-24 18:04, Greg Chicares wrote:
GC> > GC> > On 2018-04-24 14:26, Vadim Zeitlin wrote:
GC> > GC> [...]
GC> > GC> >>  I can't help wondering why
GC> > GC> >> exactly can't this class be moved in wx_table_generator.cpp?
GC> > GC> > 
GC> > GC> > I would very much like to move it there, but I tried doing exactly 
that,
GC> [...]
GC> > So this points immediately to the problem: we can't compile inline
GC> > columns_count() without full column_info class definition. But this is not
GC> > really a problem at all, we just need to move columns_count() out of line
GC> > and define it in wx_table_generator.cpp too.
GC> 
GC> Okay, I moved both inline functions out of line.

 Sorry, there is a third one, too. I didn't notice it because I only tested
group_quote_pdf_gen_wx.cpp compilation (which gave the error in your
original email) and it didn't use it, but ledger_pdf_generator_wx.cpp does.
The solution is the same as before, i.e. the following patch (on top of
your odd/vector-fwd-decl branch) really fixes the build:

---------------------------------- >8 --------------------------------------
diff --git a/wx_table_generator.cpp b/wx_table_generator.cpp
index e46a58374..542a16095 100644
--- a/wx_table_generator.cpp
+++ b/wx_table_generator.cpp
@@ -255,6 +255,7 @@ void increase_to_if_smaller(T& first, T second)
     dc_.SetPen(pen);
 }

+wx_table_generator::wx_table_generator(wx_table_generator const&) = default;
 wx_table_generator::~wx_table_generator() = default;

 void wx_table_generator::use_condensed_style()
diff --git a/wx_table_generator.hpp b/wx_table_generator.hpp
index 60f902612..9f7eadad2 100644
--- a/wx_table_generator.hpp
+++ b/wx_table_generator.hpp
@@ -51,6 +51,7 @@ class wx_table_generator
     // The table has the given total width and starts at the left margin.
     wx_table_generator(wxDC& dc, int left_margin, int total_width);

+    wx_table_generator(wx_table_generator const&);
     ~wx_table_generator();

     // Adds a column to the table. The total number of added columns determines
---------------------------------- >8 --------------------------------------

 Regards,
VZ