Re: [lmi] [PATCH] Add script allowing to install any wxWidgets version from Git

[Greg Chicares]

On 2018-04-09 00:13, Vadim Zeitlin wrote:
> On Sun, 8 Apr 2018 23:36:21 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> The less conditional logic, the better.
> 
>  I disagree with this because IMO it's confusing to perform clearly useless
> actions, but it doesn't matter anyhow...

I spent a really long time trying to figure out the conditional logic.
I was trying to satisfy myself that it was correct, before asking Kim
to run it. It's good that I did, because...

> .. because there is indeed a real problem here.

Then I saw that I could reduce the complexity considerably. I don't
mind repeating a few idempotent operations that cost hundredths of a
second, in a script that takes minutes to run.

Simpler code is easier to review, understand, and maintain--and
likelier to be correct.

> GC> In the same vein, is there any strong reason not to unconditionalize
> GC> the code that handles submodules?
> 
>  Same one as above: it's an optimization, we know for sure that these
> commands won't do anything, so why bother running them?

We're sure that running them won't affect correctness. So why write
code to avoid running them when doing so might introduce defects?