Re: [lmi] Unit test for PDF get_extra_pages_needed() function

[Vadim Zeitlin]

On Mon, 12 Feb 2018 13:55:58 +0000 Greg Chicares <address@hidden> wrote:

GC> We've reached a decision. You have two choices, so please pick whichever
GC> produces the cleanest, most maintainable code in the end:
GC> 
GC> (1) Do exactly what the production system does, as described above for
GC> '--pyx=only_old_pdf'.
GC> 
GC> (2) If there are zero data rows, print a special PDF file containing
GC> only a string like this:

 Just to be sure: does this mean that this PDF file should contain just a
single page with this string? No cover page, no pages without tabular data?
Also, no header/footer on this single page?

 Independently of the answer to these questions, (1) above would be simpler
to implement and so would result in most maintainable code. However I still
think that it's not a good solution from the user point of view, so I don't
know if I should really follow your advice and pick (1) even though I
believe it wouldn't result in the best behaviour or do what I consider
would be better, even if it contradicts your guideline above.

GC> Whichever option you choose, show no diagnostic in the zero-rows case:
GC> IOW, it's not an exceptional condition. Accordingly, do not delete the
GC> PDF file.

 Yes, sure, this goes without saying. This question was more general, i.e.
what should we do if the code generating the PDF still throws an exception,
for some other reason (it won't throw it any more just because the contract
lapsed). And I would still be interested in an answer to it, even if it's
not urgent, of course.

 Thanks,
VZ