Re: [lmi] [lmi-commits] master 53e1802 4/8: Use a gainlier name for source directory

[Vadim Zeitlin]

On Thu, 18 May 2017 22:45:45 -0400 (EDT) Greg Chicares <address@hidden> wrote:

GC> branch: master
GC> commit 53e1802120a17c69a822907c9806d57c2d5774e7
GC> Author: Gregory W. Chicares <address@hidden>
GC> Commit: Gregory W. Chicares <address@hidden>
GC> 
GC>     Use a gainlier name for source directory
GC> ---
GC>  install_wx.make       |  5 ++++-
GC>  install_wxpdfdoc.make | 10 +++++++---
GC>  2 files changed, 11 insertions(+), 4 deletions(-)
GC> 
GC> diff --git a/install_wx.make b/install_wx.make
GC> index bf2a920..e2fb311 100644
GC> --- a/install_wx.make
GC> +++ b/install_wx.make
GC> @@ -75,7 +75,9 @@ ifneq ($(use_git), N)
GC>    wx_commit_sha     := 41045df7ea5f93e4c07c1bd846d7127a372705bd
GC>    wx_md5            := 89775012799fe5c9bd8ea61e5fa43da7
GC>  
GC> -  wx_version        := $(wx_commit_sha)
GC> +# Use a string distinct from any official wxwidgets.org release name
GC> +# and from any such string previously used in this makefile.
GC> +  wx_version        := 3.1.0-p1

 FWIW I think the string returned by "git describe", e.g. something like
v3.1.0-1337-g33b0a70 currently for me (I swear the leetspeak is wholly
incidental), is more useful as it's still relatively readable, but also
uniquely identifies the version being used.

 In fact, I think it would be nice(r) to use this string as part of the
vendor string too.

 Regards,
VZ