[lmi] for(;;) ... break;

[Greg Chicares]

I've been reviewing every iterator and every for-statement in lmi,
and modernizing them wherever that seemed wise. After working through
Vadim's massive changes
  https://patch-diff.githubusercontent.com/raw/vadz/lmi/pull/52.patch
| 49 files changed, 310 insertions(+), 525 deletions(-)
I made some further changes, and now I've gone back and reviewed every
  /::iterator/
  /::const_iterator/
  /::for *(/
  /::for$/
and made a couple of final modernizations, which I'll commit and push
soon; and that concludes this particular modernization task.

I decided not to make a certain few potential modernizations for reasons
previously discussed here. Here's another one, which occurs more than once:

     std::vector<double> tabular_Ax;
+    for(auto const& j : CvatCorridorFactors)
+        {
+        LMI_ASSERT(0.0 < j);
+        tabular_Ax.push_back(1.0 / j);
+        }
-    for(int j = 0; j < input.years_to_maturity(); ++j)
-        {
-        LMI_ASSERT(0.0 < CvatCorridorFactors[j]);
-        tabular_Ax.push_back(1.0 / CvatCorridorFactors[j]);
-        }
     tabular_Ax.push_back(1.0);

I won't make that change because I feel it would be better handled
with expression templates:
     std::vector<double> tabular_Ax = 1.0 / CvatCorridorFactors;