Re: [lmi] [PATCH] Better support for non-x87 platforms

[Vadim Zeitlin]

On Thu, 5 Jan 2017 03:47:48 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2017-01-04 14:41, Vadim Zeitlin wrote:
GC> > On Wed, 4 Jan 2017 13:45:47 +0000 Greg Chicares <address@hidden> wrote:
GC> > 
GC> > GC> On 2017-01-03 15:14, Vadim Zeitlin wrote:
GC> > GC> > 
GC> > GC> >  As promised, here are the changes which allow to set rounding mode 
when
GC> > GC> > not using x87 and so make the "round" and "round_to" tests pass in 
64 bit
GC> > GC> > builds: https://github.com/vadz/lmi/pull/49
GC> 
GC> BTW, how is it that we can do things like this:
GC> +    int z = fegetround();
GC> when the only applicable header we include is <cfenv>?
GC> Shouldn't 'std::' be required?

 Yes, it really like it should -- even though in practice it isn't (because
this code compiles...) with gcc, probably because it inadvertently pulls in
fenv.h.

 It's a trivial change, so I won't propose to make a patch for it, but it
should still be changed.

 Sorry for not noticing this,
VZ