Re: [lmi] "'SetFocus' failed" in automated GUI test

[Vadim Zeitlin]

On Thu, 20 Oct 2016 01:24:28 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2016-10-19 23:04, Vadim Zeitlin wrote:
GC> > On Wed, 19 Oct 2016 21:50:00 +0000 Greg Chicares <address@hidden> wrote:
GC> [...]
GC> > GC>   cd /opt/lmi/bin
GC> > GC>   ./wx_test.exe --data_path=/opt/lmi/data --distribution >eraseme 2>&1
GC> > GC> Symptom: output file begins:
GC> > GC> 
GC> > GC> In file ../src/msw/window.cpp at line 558: 'SetFocus' failed with 
error 0x00000057 (the parameter is incorrect.).
GC> > GC> In file ../src/msw/window.cpp at line 558: 'SetFocus' failed with 
error 0x00000057 (the parameter is incorrect.).
GC> > GC> NOTE: starting the test suite
GC> > GC> about_dialog_version: started

 I've now tried reproducing this myself, but, unfortunately, I just don't
see it. I've tested with and without "--distribution" option and with and
without "-t about_dialog_version" (i.e. I also tested running the entire
test suite instead of just this test, even though, apparently, it should
have been sufficient to run just it to see the error) and never saw these
messages.

GC> > GC>     mainWin->SetFocus();
GC> > GC>     wxPuts("NOTE: starting the test suite");
GC> > GC> [It's plausible to guess that this is the failing SetFocus() call.
GC> > 
GC> >  One thing we could do easily would be to show the window class/name in 
the
GC> > error message, which could be used to confirm this guess.
GC> 
GC> Would you please speak the magic incantation to show that extra information,
GC> which comes more easily to you than to me? This probably doesn't even merit
GC> a formal patch: just say how to change it, and we'll test it.

 Sorry if I was being unclear, by "we" above I meant "wxWidgets developers"
because the idea was to change wxWidgets to do it, i.e. include
window->GetClassName() and/or GetName() when giving the error message in
wxWindowMSW::SetFocus(). There is no reasonable way to get this information
from outside wxMSW I'm afraid. I'd still like to do it, but you would need
to update your wx version or apply a separate patch for this to work. Would
this be acceptable?

 Thanks,
VZ