Re: [lmi] Allow switching skin while lmi is running

[Vadim Zeitlin]

On Mon, 30 May 2016 20:14:42 +0000 Greg Chicares <address@hidden> wrote:

GC> Dynamic skin selection was the hard part; adding other members of
GC> class configurable_settings would be easy, and this is probably
GC> the best time to add any that we want. Here's a list of that
GC> class's members, along with some layout ideas.
GC> 
GC> ----configurable_settings member---  --tab--    ----control type---
GC> calculation_summary_columns_         view       array of comboboxes
GC> use_builtin_calculation_summary_     view       checkbox
GC> default_input_filename_              input      textctrl
GC> skin_filename_                       input      listbox or combobox
GC> print_directory_                     reports    textctrl
GC> seconds_to_pause_between_printouts_  reports    spinctrl
GC> spreadsheet_file_extension_          reports    textctrl
GC> custom_input_0_filename_             custom     textctrl
GC> custom_input_1_filename_             custom     textctrl
GC> custom_output_0_filename_            custom     textctrl
GC> custom_output_1_filename_            custom     textctrl
GC> cgi_bin_log_filename_                internal   textctrl
GC> libraries_to_preload_                internal   textctrl
GC> offer_hobsons_choice_                internal   checkbox
GC> xsl_fo_command_                      internal   textctrl

 I don't have anything to add to this list, I just wanted to say that it
would be better to choose wxFilePickerCtrl and wxDirPickerCtrl for
default_input_filename_ and print_directory_ respectively, instead of plain
wxTextCtrl.

GC> Now that "File | Preferences" shows multiple tabs, I shortened the
GC> tab label "Calculation summary columns" to "View" to prevent it
GC> from scrolling out of view when the other tab is selected.

 This is indeed nice, I didn't want to change the tab label on my own, but
I'm glad you did it.

GC> I looked at class global_settings; the only option there that
GC> might arguably be added to "File | Preferences" is data_directory,
GC> but that might not be feasible because this dialog edits the file
GC>   ${data_directory}/configurable_settings.xml
GC> so there's a self-reference problem.

 There is also the fact that this dialog is loaded from an XRC file under
$data_directory. The only possibility I can think of for this one is to ask
the user to specify the data directory on startup if it doesn't exist or
doesn't contain configurable_settings.xml file. IMHO this could be useful,
but it's not directly related to this dialog.

GC> I also looked at the "pyx"
GC> and "idiosyncrasy" options and concluded that most of them are
GC> hidden for good reasons:
GC>   idiosyncrasyT is useful only for debugging
GC>   idiosyncrasyV is pretty much obsolete
GC>   idiosyncrasy_daily_interest_accounting would ideally be
GC>     a member of class Input, just like the general-account rate
GC>   idiosyncrasyZ and pyx=values_tsv would ideally be menu commands

 Should I look into doing this or was this just an abstract remark and not
a call for action?

GC> This would be a good time to suggest anything else that we might
GC> want to show on this dialog.

 As I already said, I can't think of anything, but I can add the 4 fields
you think it would be useful to have there if you'd like.

 Please let me know if I should do this,
VZ