Re: [lmi] Improved input-sequence editor

[Vadim Zeitlin]

On Sat, 28 May 2016 01:40:18 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2016-05-13 00:35, Greg Chicares wrote:
GC> > Reference:
GC> >   https://github.com/vadz/lmi/pull/25/
GC> 
GC> And pull/26 too. I've pushed all those changes.

 Thanks!

GC> The only alteration I made
GC> was reformatting the commit messages to shorten lines thus:
GC>   
http://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting

 Unfortunately 50 characters limit is really too short for me (I do realize
that it's probably my problem rather than that of the guideline). And as
with all limits it helps to understand its rationale: it's meant to ensure
that even after adding a "[PATCH]" prefix and a couple of "Re:"s to it, the
subject still fits into 80 characters, so it's mostly important for email-
based workflows. I don't think it's that important for lmi and I think we
could relax it a bit... I use 65 personally and it seems to work well.

 BTW, it really was _not_ an exception and git commit messages from
Savannah don't have any subject for non-summary messages. This probably
bothers me more than it should, do you think it's worth asking Savannah
admins about this?


GC> >, and I don't think we should commit
GC> > this patchset #25 until after that release, but I'd like to make
GC> > some comments now.
GC> [...]
GC> > (1) When I pop up the tabbed input dialog (instead of editing in
GC> > the wxDataView census manager directly) and focus an input-sequence
GC> > control (without opening the input-sequence editor), the "OK"
GC> > pushbutton is highlighted, and I expect that (as previously)
GC> > pressing Enter will push "OK". But it does nothing. Instead, I think
GC> > Enter really should press "OK".
GC> 
GC> This is what bothers me most.

 I'll try to fix this a.s.a.p.

 Thanks again for merging this!
VZ