[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] MDI child frame and wxEVT_MENU_HIGHLIGHT
From: |
Greg Chicares |
Subject: |
Re: [lmi] MDI child frame and wxEVT_MENU_HIGHLIGHT |
Date: |
Wed, 30 Mar 2016 18:06:52 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 |
On 2016-03-30 14:26, Vadim Zeitlin wrote:
> On Wed, 30 Mar 2016 14:16:29 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> Thus, unless I'm missing something, 'docmdichildframe_ex.?pp' should be
> GC> eradicated.
>
> To be honest, I don't remember if I hadn't noticed this before submitting
> the patch or consciously decided not to propose removing it because I
> didn't want to change too many things at once (I think it was the latter,
> but I might be only thinking it with the benefit of hindsight), but looking
> at it objectively, these files, and DocMDIChildFrameEx class, are indeed
> perfectly useless. And as it's only used in a single place, when creating
> the child in Skeleton::CreateChildFrame(), it's pretty simple to get rid of
> it too. Should I make a patch doing it or will you just do it yourself?
It's mine, so I'll do it myself, like Melvyn Douglas in "Hud" if you're
into classic revisionist westerns.
Change a line in 'skeleton.cpp' (which is most unlikely to collide with
any patch you may have outstanding); 'svn remove' two files; and remove
those two files from all makefiles--should be easy enough.